Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Document charts plugin #2695

Merged

Conversation

joshuarrrr
Copy link
Member

@joshuarrrr joshuarrrr commented Oct 28, 2022

Description

  • Update README with full capabilities
  • Add current_usage doc to track current usage

The primary value in documenting usage is to identify UX gaps to close as part of #2667, #2507, and #2385

Issues Resolved

fixes #2585

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@joshuarrrr joshuarrrr requested a review from a team as a code owner October 28, 2022 23:33
kavilla
kavilla previously approved these changes Oct 29, 2022
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thx!

joshuarrrr added a commit to joshuarrrr/OpenSearch-Dashboards that referenced this pull request Oct 31, 2022
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr added a commit to joshuarrrr/OpenSearch-Dashboards that referenced this pull request Oct 31, 2022
Signed-off-by: Josh Romero <rmerqg@amazon.com>
@joshuarrrr joshuarrrr force-pushed the docs/charts-plugin-readme-usage branch from f9a05d3 to 4d8a9a7 Compare October 31, 2022 19:18
ananzh
ananzh previously approved these changes Oct 31, 2022
kavilla
kavilla previously approved these changes Nov 2, 2022
@@ -0,0 +1,180 @@
# Usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i'm not convinced this is the right place to have this information. Seems like the forked docsite might be a better place, but not sure how maintained that is currently.

Didnt others create similar docs on how other plugins work, e.g. How visualizations work using a flowchart. where did we share that?

One other alternative to pave the way could be to just have it here but call it something more appropriate like Current_useage.md. Developer guide is what threw me off the most. That usually means something else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, in this new revision, I've moved to the docs directory and renamed.

Didnt others create similar docs on how other plugins work, e.g. How visualizations work using a flowchart. where did we share that?

Not that I know of? I think some information like that is simply in GitHub issues, such as #2187

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that! That seems like a better place for high level information like this for now while we decide on the best place to consolidate this.

@AMoo-Miki AMoo-Miki added docs Improvements or additions to documentation v2.4.0 'Issues and PRs related to version v2.4.0' v2.5.0 'Issues and PRs related to version v2.5.0' and removed v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 5, 2022
* Update README with full capabilities
* Add `DEVELOPER_GUIDE` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
- Re-order and reorganize some headers
- Add issue links

Signed-off-by: Josh Romero <rmerqg@amazon.com>
@joshuarrrr joshuarrrr dismissed stale reviews from kavilla and ananzh via c4eeb7b November 15, 2022 02:32
@joshuarrrr joshuarrrr force-pushed the docs/charts-plugin-readme-usage branch from 4d8a9a7 to c4eeb7b Compare November 15, 2022 02:32
@joshuarrrr joshuarrrr merged commit 80cf748 into opensearch-project:main Nov 18, 2022
@joshuarrrr joshuarrrr deleted the docs/charts-plugin-readme-usage branch November 18, 2022 18:53
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 18, 2022
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 80cf748)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kavilla pushed a commit that referenced this pull request Nov 23, 2022
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 80cf748)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Sergey Osipov <sipopo@yandex.ru>
@ananzh ananzh mentioned this pull request Jan 11, 2023
1 task
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
- Update README with full capabilities
- Add `current_usage` to track current usage

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x docs Improvements or additions to documentation v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Research] Document charts plugin
6 participants