-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Document charts
plugin
#2695
[Doc] Document charts
plugin
#2695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thx!
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
f9a05d3
to
4d8a9a7
Compare
@@ -0,0 +1,180 @@ | |||
# Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i'm not convinced this is the right place to have this information. Seems like the forked docsite might be a better place, but not sure how maintained that is currently.
Didnt others create similar docs on how other plugins work, e.g. How visualizations work using a flowchart. where did we share that?
One other alternative to pave the way could be to just have it here but call it something more appropriate like Current_useage.md
. Developer guide is what threw me off the most. That usually means something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, in this new revision, I've moved to the docs
directory and renamed.
Didnt others create similar docs on how other plugins work, e.g. How visualizations work using a flowchart. where did we share that?
Not that I know of? I think some information like that is simply in GitHub issues, such as #2187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that! That seems like a better place for high level information like this for now while we decide on the best place to consolidate this.
* Update README with full capabilities * Add `DEVELOPER_GUIDE` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
- Re-order and reorganize some headers - Add issue links Signed-off-by: Josh Romero <rmerqg@amazon.com>
4d8a9a7
to
c4eeb7b
Compare
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 80cf748) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 80cf748) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com>
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com>
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Sergey Osipov <sipopo@yandex.ru>
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Description
current_usage
doc to track current usageThe primary value in documenting usage is to identify UX gaps to close as part of #2667, #2507, and #2385
Issues Resolved
fixes #2585
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr